Update basestyle.ts with avoid global 'box-sizing:border-box' #17502
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@SergiOn is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
|
@tundisto |
mertsincan
added
the
Status: Discussion
|
+1 We need this box-sizing to be scoped to the primeng framework as well, it has impact on our whole application otherwise. |
| *[class^="p-"], | ||
| *[class*=" p-"], | ||
| *[class^="p-"]::before, | ||
| *[class*=" p-"]::before |
There was a problem hiding this comment.
| *[class*=" p-"]::before | |
| *[class*=" p-"]::before, |
|
@mertsincan @cagataycivici PrimeNG is designed to be design agnostic. Scoping this css to the PrimeNG namespace is the correct solution, no? Update To be clear, we're not using one of the provided themes in our application, so #7383 did not affect us in v17. It however does affect us when trying to upgrade to v18. I can understand you want to avoid doing incompatible changes to the themes, but we can't upgrade to v18 atm, so imo the impact of #7383 is larger than it was in v17. |
|
@SergiOn would you mind applying the suggestion from @tri-harmoney ? |
Defect Fixes
#7383
We have a global
box-sizing: border-boxwhich break default browser behavior.Overriding this style locally to default, except "PrimeNG", breaks other local libraries.
This PR add "box-sizing: border-box" just for "PrimeNG" name space
Feature Requests
Apply
box-sizing: border-boxfor "PrimeNG" name space avoid to apply "box-sizing: border-box" globally